Repository navigation
Allow absolute artifact paths only as metadata - #61
Merged
Merged
Conversation
The readiness pass refused absolute paths at construction, which broke dau-build: its whole artifact model records where an output landed on the build host. The model now refuses only a path that climbs out of its manifest root with .., and the three places artlink would act on a path (registry resolution, packaging, materialization planning) refuse an absolute one explicitly instead. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Contributor
Test Results76 tests +1 76 ✅ +1 5s ⏱️ +2s Results for commit e36b45f. ± Comparison against base commit d511656. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 91.39% 91.52% +0.13%
==========================================
Files 30 30
Lines 2625 2644 +19
Branches 223 225 +2
==========================================
+ Hits 2399 2420 +21
+ Misses 136 134 -2
Partials 90 90 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#57 refused absolute artifact paths at construction. Running dau-build's suite against artlink main shows that breaks 38 of its tests: dau-build's artifact model records where each output landed on the build host (bitstreams, reports, generated inputs, contributing HDL sources from other checkouts), as absolute paths, and reads them back the same way. CI did not catch it because dau-build installs the released artlink.
This keeps the containment where artlink acts on a path and drops it where artlink only carries one:
.., and accepts an absolute path as "a file on this host".ArtifactRegistry.artifact_file_path,build_package_archiveandbuild_materialization_planrefuse an absolute path explicitly (before this they would have resolved outside the root, tried to pack it under the package root, or written it at an absolute destination; Fix artifact path containment and archive validation #58's resolved-path checks would have caught the last two, but with a less direct message).This partly reverses one line of the readiness decision; the alternative, moving dau-build and its consumers to manifest-relative paths plus
file:URIs for external provenance, is a multi-repository change that the containment the registry and materializer already enforce does not justify.