Repository navigation
Publish manifest JSON Schema and document version ordering - #60
Merged
Merged
Conversation
artlink.manifest/v0 now has a JSON Schema at artlink/schemas/artlink.manifest-v0.json, generated from the Manifest model by manifest_json_schema() and held equal to it by a test; written manifests and the README's examples validate against it, and the schema refuses what the model refuses. The README states the version comparison rule the highest policy uses, including that it is lexical and sorts a pre-release suffix above its release. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 91.39% 91.51% +0.11%
==========================================
Files 30 31 +1
Lines 2625 2662 +37
Branches 223 224 +1
==========================================
+ Hits 2399 2436 +37
Misses 136 136
Partials 90 90 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timkpaine
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decisions Z2 and Z3 from the readiness review.
artlink.manifest/v0has a published JSON Schema,artlink/schemas/artlink.manifest-v0.json, generated from theManifestmodel by the newmanifest_json_schema()and held equal to it by a test (regenerate from that function when the model changes). Written manifests and the README's manifest examples validate against it, and the schema refuses what the model refuses: unknown keys, a missing name, a reference kind resolution does not implement.jsonschemajoins the develop extra for the tests.highestpolicy uses: digit runs as integers, other runs as text, digit below text at the same position, a longer version above its prefix. It also says what that means: the rule is lexical, so2.0.0-rc1sorts above2.0.0, and ecosystems with pre-release conventions should pin versions in their references. The rule itself is unchanged (Z2 keeps artlink's own design).