Repository navigation
test: fix reachability e2e delete/rebuild race - #902
Open
polylane[bot] wants to merge 1 commit into
Open
polylane[bot] wants to merge 1 commit into
polylane[bot] wants to merge 1 commit into
Conversation
The reachability e2e step deleted the projected hub copy with a blocking delete, then waited for the copy to be gone. The cell's writeback controller rebuilds the copy within the same second, so the wait never observed absence and the step failed with "context deadline exceeded" even though the copy was back. Key changes: - Delete the hub copy with --wait=false and poll for a replacement carrying a new UID, matching the pattern already used in networkinterfaceclaim-bound-interface-delete. Co-authored-by: polylane[bot] <277585245+polylane[bot]@users.noreply.github.com>
scotwells
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end-to-end check that deletes a projected copy on the hub and expects it back failed on CI even though the copy was back. Its delete helper also waited for the copy to disappear, but the controller rebuilds it within the same second, so that wait never won and the step reported a deadline error. The check now deletes without waiting and confirms a fresh copy appears. Chainsaw's delete operation polls until the resource is gone, and rebuilds land in the same second, so the operation times out although the behavior under test is correct. The step now deletes without waiting and polls for a replacement with a new UID, the same pattern the repository already uses for this race.
Fix walkthrough
Watch the fix explained (1:01). Recorded for commit
98e4be29e98340d7e1ffd38302dca8ff3ffff785.Production impact
Reachability e2e test edit touches no deployed resource
The diff only edits a Chainsaw test file under
test/e2e/; it changes no operator source and reaches no deployed resource. The repository's only outbound edge isdefinesto theghcr.io/datum-cloud/network-services-operatorimage, whose built artifact this test file does not affect, so no runtime behavior changes on merge.Observability
vpcendpointslice-reachability-eventscenario must stay green.timed out waiting for the hub copy to come back: original UID <uid>, last observation <uid|deletionTimestamp>on failure, naming the UID and deletion state it saw.Polylane assessed this pull request at
98e4be2.Causal chain
1 file changed (+23/-6)
test/e2e/vpcendpointslice-reachability-event/chainsaw-test.yaml: modified, +23/-6Repository lint:
make lint(declared in CLAUDE.md) did not finish within its time budget, so its verdict is not known; run it before merging.Generated by Polylane. You can ask follow-ups by mentioning @polylane in a comment. If you close this pull request without merging, add a comment that says why. Polylane reads it to make its next fixes better.