Repository navigation
Conversation
…work Backport of #851 to release/v0.34.
Contributor
Author
|
Review note: the diff is byte-identical to #851's merge diff on main ( |
JoseSzycho
approved these changes
Nov 3, 2026
Contributor
Author
|
Closing, #851 will ship in v0.35.1 after v0.35.0 rolls out to production, instead of a v0.34.3 patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Scot Schuchert-Wells
What
Backports #851 to
release/v0.34, for a v0.34.3 patch release. The internal DNS controller labels each network's DNSResolverContext withnetworking.datumapis.com/networkandnetworking.datumapis.com/network-uid. It also setskubernetes.io/description: Private DNS for the <network> VPCand asks DNS to copy the labels to the managed zone (dns.networking.miloapis.com/managed-object-labels). Existing contexts are updated on the next pass, and failed writes are only logged.Why
Production runs v0.34.2. Releasing from main would bring about 50 other PRs, including a Network mutating webhook production doesn't route yet. This patch carries only #851. dns-operator v0.13.0, already in production, copies these labels and the description onto each managed
datum.internalzone, so the portal shows which VPC a zone is for.The cherry-pick applies cleanly onto v0.34.2, and it builds and passes
go test ./internal/controller/.Related: datum-cloud/enhancements#921