Repository navigation
test: Give the internal error test a tracker key of its own - #850
Merged
Merged
Conversation
The HTTPProxy programming tracker is the process's own. TestHTTPProxyReconcile programs proxy test/test on test-cluster, and the tracker then skips that key's next unprogrammed generation, so this test's pending entry was never written. It passed in the default order only because TestHTTPProxyFleetCollector runs between the two, and its collector prunes the same tracker. Under -shuffle it failed. The test now reads a cluster name no other test uses.
scotwells
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestHTTPProxyReconcileInternalErrorGetsStableFixedMessagefails under-shuffleonmain, and it fails every time it runs right afterTestHTTPProxyReconcile. The HTTPProxy programming tracker is one per process, andTestHTTPProxyReconcileprograms proxytest/testontest-cluster, so the tracker skips the next unprogrammed generation of that key and this test's pending entry is never written. It passes in the default order only becauseTestHTTPProxyFleetCollectorruns between the two, and its collector prunes the same tracker. The test now reads a cluster name that no other test uses, so it still checks the tracker that production reads.Changes
internal-error-clusterhttpproxy_metrics_test.goTest plan
go test ./internal/controller/ -run '^(TestHTTPProxyReconcile|TestHTTPProxyReconcileInternalErrorGetsStableFixedMessage)$'fails onmainand passes here.-shufflefails 3 of 10 seeds onmainand none here, and-count=2passes.golangci-lintpasses.Found while running the controller package under
-shufflefor #837.