Repository navigation
ci: Give the test run 25 minutes until the suite is split - #845
Merged
Merged
Conversation
On main the controller package takes 1131-1170 s of the required check's 1200 s go test timeout, and #844 hit it while its tests passed in the Tests workflow. CI and make test move to 25 minutes together. The job stays under ci-basic's 30-minute cap: about 4 minutes of steps come before the tests. #837 tracks the split that removes the need.
andrewb3000
approved these changes
Nov 3, 2026
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required
ci / Build and testcheck stopsgo testat 20 minutes, and onmainthe controller package already takes 1131 to 1170 of those 1200 seconds (numbers on #837). #844 hit the limit while the Tests workflow passed the same package in 1132 s, so the required check now blocks a fix. This raises the test timeout to 25 minutes inci.yamland in the Makefile, so CI andmake testagree, until #837 splits the suite. The job stays under the shared workflow's 30-minute cap: it took 22m45s to 23m47s onmainin its last five runs, and on #844 its steps before the tests took 3m43s, so a 25-minute test run ends by about 28m45s.Changes
go test -timeout 25m, with the reason beside it.github/workflows/ci.yamlmake testuses the same timeoutMakefileTest plan
main.Related to #837