Skip to content

fix: Bring back every network presence when the controller starts #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvoytovych merged 4 commits into from
Nov 3, 2026
Merged

fix: Bring back every network presence when the controller starts #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4cddc63
test: Cover a presence nothing declares across a restart
vvoytovych Nov 3, 2026
b690f33
fix: Bring back every network presence when the controller starts
vvoytovych Nov 3, 2026
adacc2c
test: Cover a presence declared only in its project across a restart
vvoytovych Nov 3, 2026
ff399fe
Merge branch 'main' into fix/presence-reconciles-every-presence-on-start
vvoytovych Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/controller/networkpresence_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,6 +850,12 @@ func (r *NetworkPresenceReconciler) SetupWithManager(mgr manager.Manager) error
r.hub = mgr.GetClient()

builder := ctrl.NewControllerManagedBy(mgr).
// A presence is keyed as the hub's copy of its context is: the same
// namespace and name. The copy lasts as long as the presence does, so the
// list of copies on start brings back every presence, the ones nothing
// declares included, whose waits went with the process that set them.
For(&networkingv1alpha.NetworkContext{}).
// A binding declares a presence, also before its context has a copy.
Watches(&networkingv1alpha.NetworkBinding{}, handler.EnqueueRequestsFromMapFunc(
func(_ context.Context, obj client.Object) []reconcile.Request {
binding, ok := obj.(*networkingv1alpha.NetworkBinding)
Expand Down
5 changes: 4 additions & 1 deletion internal/controller/networkpresence_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
apimeta "k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/rest"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/cluster"
Expand Down Expand Up @@ -51,6 +52,7 @@ type presenceScenario struct {
ctx context.Context

hub client.Client
restConfig *rest.Config
reconciler *NetworkPresenceReconciler

hubNamespace string
Expand Down Expand Up @@ -79,7 +81,7 @@ type presenceOptions struct {

func newPresenceScenario(t *testing.T, opts presenceOptions) *presenceScenario {
t.Helper()
cl, _ := startNetworkInterfaceEnv(t)
cl, cfg := startNetworkInterfaceEnv(t)
ctx := context.Background()

suffix := sanitizeName(strings.ToLower(t.Name()))
Expand All @@ -90,6 +92,7 @@ func newPresenceScenario(t *testing.T, opts presenceOptions) *presenceScenario {
t: t,
ctx: ctx,
hub: cl,
restConfig: cfg,
hubNamespace: "hub-" + suffix,
projectNamespace: "proj-" + suffix,
locationName: "loc-" + suffix,
Expand Down
Loading
Loading