Repository navigation
feat: Run the catalog on the shared workflows - #244
Merged
Merged
Conversation
This catalog's index rebuild and release scan pushed with the built-in token, so GitHub held every run they triggered until a maintainer approved it, and its pull request check passed without validating any manifest. The catalog now uses the shared plugin catalog workflows from datum-cloud/actions v1.27.1. The rebuild and scan push with the release bot's GitHub App, so CI runs on their pull requests without an approval, and validation checks every manifest, runs datumctl's own validator, and downloads the archives a pull request changes. Its own scripts and schema copy go. The index has no header, as before, so what datumctl reads doesn't change. Fixes #236 Fixes #37 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ecv
approved these changes
Nov 10, 2026
ecv
left a comment
Contributor
There was a problem hiding this comment.
Approve.
Callers match the Milo catalog's (same shared workflows at datum-cloud/actions@v1.27.1, a release tag, with least-privilege permissions and no secrets: inherit), the required check name ci / Build and test is preserved, and removed scripts have no remaining callers.
- This passes
RELEASE_BOT_APP_ID/RELEASE_BOT_APP_PRIVATE_KEYwhere Milo passesPLUGIN_INDEX_APP_*. The release bot secrets are used by the plugin release workflows in compute, network-services-operator and dns-operator, so they are likely org-wide, but confirm the App is installed on this repo with contents and pull request write. If not, rebuild and scan fail at the token mint, which the unchecked test-plan item would catch. - The shared schema is stricter than the deleted one (
additionalProperties: falseon platforms, HTTPS-onlyuripattern). The PR says all manifests pass; worth confirming that held on the latestplugins/at merge time. catalog-healthpasses noname,description,ownerorhomepage, and the rebuild passes none either, so the index header stays bare like today'sindex.yaml. The two are consistent. Milo sets all four, so a catalog name indatumctl plugin index listis a possible follow-up.
Follow-ups:
- The rebuild branch changes from
chore/regen-indextoregenerate-index; no PR is open on the old branch today, but delete the stale branch if one exists. - Auto-merge on the rebuild PR needs repo auto-merge enabled and the App allowed by the branch rules, per the shared README; check once after the first run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This catalog's index rebuild and release scan push with the built-in token, so every pull request they open needs a maintainer to approve its workflow runs, and its pull request check passes without validating any manifest.
This moves the catalog to the shared plugin catalog workflows, which push with the release bot's GitHub App and validate every manifest, as the Milo catalog already does. The published index stays the same.
Test plan
Fixes #236
Fixes #37
🤖 Generated with Claude Code