Repository navigation
chore: Force minimatch 11 for GHSA-g3hv-75wg-m249 - #44
Merged
Merged
Conversation
A crafted glob pattern can stall the process (medium). The fix exists only in minimatch 11.0.1+, and every parent asks for ^10 or older, so Dependabot cannot open a fix. Pin minimatch ^10 to 11.0.4 and glob ^13 to 14.0.3 with version-scoped overrides. glob 13 bundles its own minimatch 10 copy, so forcing minimatch alone would leave the vulnerable code running inside glob; glob 14 bundles minimatch 11. This is partial. The glob 7 and minimatch 3.1.5 copies stay: glob 7 callers (rimraf 3, jest 29, test-exclude 6) use the callback and promisify API that glob 14 dropped, so a blanket override would break them.
ecv
enabled auto-merge
November 6, 2026 15:45
andrewb3000
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot cannot fix minimatch GHSA-g3hv-75wg-m249 (medium, a crafted glob pattern can stall the process) in this repo, because the fix exists only in minimatch 11.0.1+ and every parent asks for
^10or older. This PR is a partial fix: it moves the minimatch 10 and glob 13 copies to the fixed versions and deliberately leaves the minimatch 3 copies behind.What changes
package.jsonoverridesgain"minimatch@^10": "11.0.4"and"glob@^13": "14.0.3";package-lock.jsonis regenerated withnpm install --package-lock-only --ignore-scripts.What stays vulnerable, and why that is acceptable
eslint,@eslint/eslintrc,@eslint/config-array,fork-ts-checker-webpack-pluginandbroadcast-channel. Thebroadcast-channelcopy comes with glob 7.2.3 viarimraf3, pulled in byreact-query(through@strapi/plugin-users-permissions).rimraf3 calls glob's callback form, which glob 14 no longer has, and glob 7 itself needs the minimatch 3 API.react-querythat no longer depends onbroadcast-channel, and ESLint tooling moving off minimatch 3.Related toit, not a fix.Evidence
makeRe,regexp,ASTandmatchOne. The moved copies are used by@strapi/cloud-cli(minimatch()),@strapi/core(glob.glob()) andrimraf6 (glob 14), all of which stay compatible. One exception:typedoc, a dependency of@strapi/types, callsmatchOnein its file walker. Nothing in@strapi/*distor this repo invokestypedoc; it only runs from@strapi/types' owndoc:tsscript.npm run lint(0 errors, 2 existing warnings) andnpm run build(strapi build) pass on the new lock. The repo has no test script.