Skip to content

chore: stop turning on internal Claude plugins - #38

Merged
scotwells merged 1 commit into
mainfrom
claude/project-thread-4mpadv
Oct 29, 2026
Merged

scotwells merged 1 commit into
mainfrom
claude/project-thread-4mpadv

Conversation

@scotwells

Copy link
Copy Markdown
Contributor

Requested by Scot Schuchert-Wells · project thread

This repo's committed Claude Code settings turn on the internal datum-platform and datum-gtm plugins for everyone who opens it. Those plugins are moving to a private marketplace in the infra repo, which employees set up once on their own machine. This change removes the old marketplace and plugin settings so the public catalog can drop them without leaving a dirty settings file behind. Nothing else in the repo changes.

Test plan

  • The settings file no longer names the old marketplace or the internal plugins
  • Opening the repo in Claude Code shows no plugin install prompt

Generated by Claude Code

@cla-assistant

cla-assistant Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@scotwells scotwells self-assigned this Oct 29, 2026
@polylane

polylane Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Warning

Polylane could not verify the production impact of this pull request.

The only change is the deletion of .claude/settings.json, a Claude Code client settings file. I searched the resulting tree at ad38ff0 for datum-claude-code-plugins, enabledPlugins, extraKnownMarketplaces and settings.json and found no reference. The Strapi service in datum-cloud-prod and the GKE cluster never read this path, and .github/workflows/ci.yml does not either. The rebase onto 9bfc378 (CI peer-check) does not interact with it.

View the full analysis →

Also considered · 1 refuted
  • Refuted · Removing the committed Claude settings changes runtime behaviour of the deployed Strapi service · The file is a Claude Code client settings file for developers.
Analysed against 2 cloud accounts and 1 repository

View in Polylane Pause assessments

Polylane could not find the cloud resources this repository manages, so this review looked at the entire cloud account. Connect this repository to its resources and the next review will focus on exactly what this code deploys to.

Connect resources

Polylane analysed ad38ff0 for production impact. You can ask follow-ups by mentioning @polylane in a comment.

Rate this review: 👍 helpful · 👎 not helpful · 😕 confusing

Previous verdicts (2)
Head Verdict Analysis
3854a8d Production impact not verified analysis
bf0743e Production impact not verified analysis

@scotwells
scotwells requested review from ecv and privateip October 29, 2026 14:28
@scotwells
scotwells force-pushed the claude/project-thread-4mpadv branch from bf0743e to 3854a8d Compare October 29, 2026 14:45
The internal datum-platform and datum-gtm plugins are moving to a private
marketplace in datum-cloud/infra, which employees set up once on their own
machine. Committed settings no longer register the old marketplace or enable
those plugins, so Claude Code won't rewrite this file once they are removed
from the public catalog.
@scotwells
scotwells force-pushed the claude/project-thread-4mpadv branch from 3854a8d to ad38ff0 Compare October 29, 2026 15:07

@ecv ecv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

The change removes only the marketplace entry and the two plugin enables from .claude/settings.json. Every other setting in the file stays as it was, and the file still parses as JSON.

Follow-ups:

  • The platform and go-to-market plugins move to the private marketplace in datum-cloud/infra#7587, which is still open. If this merges first, sessions in this repo lose those plugins until people add that marketplace themselves.

@scotwells
scotwells merged commit 7133e89 into main Oct 29, 2026
3 checks passed
@scotwells
scotwells deleted the claude/project-thread-4mpadv branch October 29, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants