Repository navigation
fix: Route shell session alerts to compute - #646
Merged
Merged
Conversation
The shell-session alerts named their service compute-shell-sessions, which the platform's service catalog does not list, so no route reached a team and every one of them fell to the catch-all channel. They now name compute, the catalog's service for this namespace, whose route reaches the build team's channel, and team build, the catalog's team for compute. Key changes: - Each of the six shell-session alerts carries service: compute and team: build, as the catalog's row for compute names them - A test extracts the shipped rules: every alert names compute and build, and the availability page fires with them
ecv
approved these changes
Nov 12, 2026
ecv
left a comment
Contributor
There was a problem hiding this comment.
Approve.
The six shell session alerts now reach the build team's channel instead of the catch-all, including the two pages.
- Production's service catalog names
datum_service: computewithteam: build, and has nocompute-shell-sessionsrow, which is why the old labels routed nowhere. - Only labels change, so no alert's expression changes.
Follow-ups:
- No workflow, Taskfile or Makefile runs
test/alerts/test-shell-sessions.sh, so the new test does not gate a PR. The same holds fortest-reconcile-storm.sh. Wire both into CI, or the next label drift lands unchecked.
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell session alerts name a service and a team that the platform's service catalog does not list, so no route reaches a team and each of them lands in the catch-all channel, as several did in both environments over the last two weeks.
They now name compute and its team, build, as the catalog's row for compute names them, so their route reaches the build team's channel.
A new test reads the shipped rules, so it checks what deploys rather than a copy.
Changes
Test plan