Repository navigation
fix: Stop the rollout watch when sign-in is refused - #639
Merged
Merged
Conversation
The rollout watch treated every List error as transient and polled every 2 seconds forever. Once the sign-in token expired, each poll was refused as unauthenticated, nothing was printed, and the process never exited. Key changes: - stop the watch on 401 or 403 and tell the user to run 'datumctl login' - add a test where the credentials are refused partway through a watch
kevwilliams
approved these changes
Nov 11, 2026
kevwilliams
left a comment
kevwilliams
left a comment
Contributor
There was a problem hiding this comment.
Verified only Unauthorized and Forbidden stop the watch, other List errors still retry, and the test fails without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Scot Schuchert-Wells · project thread
When a user's sign-in expires while
deployorrolloutis watching a rollout, the watch keeps polling every two seconds forever and prints nothing. With this change the watch stops as soon as the platform refuses the credentials, either as unauthenticated or as forbidden. The user sees that the rollout continues in the background and is told to rundatumctl login. Other errors still retry as before.This covers the first acceptance criterion of #505 and adds the test it asks for. Backoff with a deadline for other errors, and refreshing the token in long-running commands, are left for follow-up PRs, so the issue stays open.
Test plan
Related to #505
Generated by Claude Code