Repository navigation
fix: stop stack trace when a shell session times out - #638
Merged
Merged
Conversation
The CLI never sets a controller-runtime logger. When a client is built more than 30 seconds after start, as happens when an exec session ends on its time limit, controller-runtime prints a "log.SetLogger was never called" warning with a full goroutine stack trace to the user's terminal. Key changes: - set a discard logger at plugin startup so the warning never fires
kevwilliams
approved these changes
Nov 11, 2026
kevwilliams
left a comment
kevwilliams
left a comment
Contributor
There was a problem hiding this comment.
Verified the CLI plugin writes all output itself and never logs through controller-runtime, so the discard logger hides nothing users need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Scot Schuchert-Wells · project thread
When a
datumctl compute execsession reaches its time limit, users see a Go stack trace printed before the expiry message. The trace is controller-runtime warning that no logger was ever set, which it only does when a client is built more than 30 seconds after the process starts, as the session cleanup does. The plugin now sets a discard logger at startup, so the warning never fires and the user just sees the expiry message. The plugin writes all user-facing output itself, so nothing else is lost.Fixes #617
Test plan
go vetpassesGenerated by Claude Code