Skip to content

perf(ui): Take shared libraries from the portal and upload source maps #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevwilliams merged 3 commits into from
Nov 4, 2026
Merged

perf(ui): Take shared libraries from the portal and upload source maps #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac520ba
perf(ui): Load the portal's shared modules instead of bundling copies
kevwilliams Nov 4, 2026
dec5f88
feat(ui): Upload the consumer plugin's source maps to Sentry
kevwilliams Nov 4, 2026
a42b893
Merge branch 'main' into perf/consumer-plugin-host-shared
kevwilliams Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@ jobs:
image-name: compute-consumer-ui-plugin
context: .
dockerfile-path: ui/consumer/Dockerfile
secrets: inherit
# The Sentry token goes in as a BuildKit secret only. `secrets: inherit`
# would also pass it to publish-docker's SENTRY_AUTH_TOKEN, which it
# forwards as a build-arg, and build-args persist in the exported cache.
secrets:
build-secrets: |
"SENTRY_AUTH_TOKEN=${{ secrets.SENTRY_AUTH_TOKEN }}"

# Deployed as a Component (config/components/provider-ui-plugin) folded
# into compute-manager's own kustomize bundle/Flux Kustomization — same
Expand Down
6 changes: 5 additions & 1 deletion ui/consumer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,11 @@ RUN npm install -g "$(node -p 'require("./package.json").packageManager')" --no-
COPY ui/consumer/ .
COPY --from=console-wasm /out/ /console-wasm/
ENV CONSOLE_WASM_DIR=/console-wasm
RUN pnpm build
# The Sentry token is a BuildKit secret (publish-docker's build-secrets), so it
# never lands in a layer, the image history or the exported build cache. When
# absent the file is missing, the variable is empty and the upload is skipped.
RUN --mount=type=secret,id=SENTRY_AUTH_TOKEN,required=false \
SENTRY_AUTH_TOKEN="$(cat /run/secrets/SENTRY_AUTH_TOKEN 2>/dev/null)" pnpm build

FROM node:26.13.0-alpine3.24@sha256:c6ad9e9c1d80f6eb607c26b4b0a132ff7a2344fad1c78ea3baa2a7d4c8de6d94
# Node keeps its own copy of the CA roots apart from Alpine's bundle. Fail the
Expand Down
1 change: 1 addition & 0 deletions ui/consumer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
},
"devDependencies": {
"@module-federation/vite": "^1.23.9",
"@sentry/vite-plugin": "5.4.1",
"@types/node": "^26.6.6",
"@types/react": "^19.3.0",
"@types/react-dom": "^19.3.0",
Expand Down
Loading
Loading