Repository navigation
fix: ignore annotation-only NetworkBinding updates in federator - #579
Merged
Merged
Conversation
kevwilliams
approved these changes
Oct 30, 2026
kevwilliams
left a comment
kevwilliams
left a comment
Contributor
There was a problem hiding this comment.
Verified the federator reads no NetworkBinding annotations, so dropping annotation-only updates cannot hide an input change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a typed predicate to the federator's NetworkBinding watch. Ignore annotation and resourceVersion bookkeeping updates while retaining spec, status, labels, ownership, finalizers, UID, and deletion changes, plus create and delete events.
This prevents bookkeeping-only binding updates from triggering unnecessary deployment reconciliation.
Validation: targeted NetworkBinding and federator tests passed. Regression coverage exercises annotation suppression and relevant spec, status, ownership, deletion, label, create, and delete events. CI, including E2E tests, passed.