Repository navigation
fix: Stop Renovate raising pnpm security-floor overrides a major - #39
Merged
Merged
Conversation
An overrides entry keyed with a version selector, such as "react-router@<6.30.6": "^6.30.6", lifts old copies of a package to a patched release on the same major. Renovate treated the value as an ordinary range and proposed raising it to the next major, which forces every copy onto that major and breaks packages that still need the old one: react-router 8 breaks Remix v2 in milo-os/activity and milo-os/service-catalog. Key changes: - Disable major updates for npm, pnpm and pnpm-workspace overrides whose key carries a version selector - Leave minor and patch updates, and overrides without a selector, untouched
This was referenced Nov 9, 2026
ecv
marked this pull request as ready for review
November 9, 2026 13:31
drewr
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate keeps proposing to raise security-floor overrides, which pin old copies of a package to a patched release, to the next major version. Merging one breaks the app, as React Router 8 breaks Remix v2 in milo-os activity and service-catalog. After this change Renovate proposes only minor and patch updates for these floors, across every milo-os repository.
Details
This stops 4 open pull requests from coming back: milo-os/activity#325, milo-os/activity#326, milo-os/service-catalog#221 and milo-os/service-catalog#222.
Warning
Security pull requests that jump a major, like milo-os/activity#302, still open. Renovate forces its security settings over any package rule, so this rule cannot block them.
Test plan
No tracking issue. Renovate's source confirms the match: workspace overrides carry dependency type
pnpm-workspace.overrides, with the full selector key as the dependency name.