Repository navigation
Use the 12-character sha in release builds; record v0.1.0 in the plan - #2
Merged
Merged
Conversation
Release builds passed the full github.sha, so v0.1.0 binaries report a 40-character sha while Docker and local builds report 12 (build.rs uses rev-parse --short=12). Both release build steps now pass GITHUB_SHA::12, as ci.yml's docker job already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups to v0.1.0:
29ebab6). v0.1.0 binaries report the full 40-character sha, while Docker and local builds report 12. Both release build steps now pass${GITHUB_SHA::12}, asci.yml's docker job already does.9185ed1): the merge, the tag and release runs, and the fork → upstream workflow (merge with a merge commit; push tags to upstream only).CI on the fork is green for
9185ed1(fmt, clippy, tests,cargo-deny, Docker build). The sha change takes effect on the next release.Please merge with a merge commit, as with #1.
🤖 Generated with Claude Code