Repository navigation
fix(search, searchset): --quick reports no row when nothing matched - #4767
Merged
Merged
Conversation
The sequential path printed row_ctr -- by then the total row count -- to stderr whenever --quick found nothing: `search` before returning NoMatch, and `searchset` when --not-one turned the no-match into a success. That reads as the row of a match. Print only when there was a match, as the indexed (parallel) path already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On an unindexed file,
--quickprinted the total row count to stderr when nothing matched. That's the same place a match's row number goes, so callers can't tell a no-match from a match on the last row.search --quickprinted it on every no-match, then exited 1.searchset --quick --not-oneprinted it and exited 0. That is exactly what a caller sees for a real match. DataPusher+'s quick PII screen ran into this: fix(pii): make PII screening work with its default regexes datapusher-plus#343 had to avoid--not-oneand read the exit code instead.The indexed (parallel) path already printed nothing on no-match. The sequential path now matches it and prints the row only when there was a match.
--quickon unindexed input, no matchsearchsearch --not-onesearchsetsearchset --not-oneTests:
search_quick_nomatch_reports_no_rowandsearchset_quick_nomatch_reports_no_rowcover plain--quick,--quick --not-one, and the indexed--jobs 2path. I mutation-checked them: with the fix reverted, both fail, with stderr"4\n"and"6\n"(the row counts). Thesearchandsearchsetsuites pass onall_features,liteanddatapusher_plus. clippy anddouble-run-checkare clean.🤖 Generated with Claude Code