Repository navigation
build(deps): require qsv-client>=0.4.0 - #350
Merged
Merged
Conversation
qsv-client 0.4.0 requires qsv 25.0.0 (DP+'s MINIMUM_QSV_VERSION) and checks it via `qsv --capabilities` before a client's first command, raising QsvVersionError for older binaries. - QSVCommand.version() maps QsvVersionError to DP+'s "At least qsv version ... required" JobError, so a too-old qsv_bin (including one without --capabilities) is reported as before. - test_ai_suggestions: the qsv_command fixture patched out the version check, so the capabilities probe ran inside each test's run_sync mock and failed; prime it at construction instead. - New test for a qsv that rejects --capabilities. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
qsv-clientto>=0.4.0(release notes). 0.4.0 requires qsv 25.0.0 — the same floor as DP+'sMINIMUM_QSV_VERSION— and runsqsv --capabilitiesbefore every client's first command, raisingQsvVersionErrorfor older binaries. DP+ uses none of the APIs 0.3.0/0.4.0 removed or changed (from_version_output,supports_json_errors,error_formats,cwd=+ relativestdout_path).QSVCommand.version()catchesQsvVersionError(now aQsvErrorsubclass) before the generic handler, so a too-oldqsv_bin— including qsv 24, which rejects--capabilities— still fails startup with DP+'sAt least qsv version 25.0.0 required. …error instead ofCannot get qsv version info…. Stale docs about the--versionfallback are updated.tests/test_ai_suggestions.py: theqsv_commandfixture patched outcheck_version, so under 0.4.0 the capabilities probe ran inside each test's mockedrun_sync(returning{}) and 11describegpttests failed withQsvError: … not a qsv --capabilities document. The fixture now primes capabilities at construction with a mocked--capabilitiesresponse.tests/test_qsv_command_client.py: new test for a qsv that answersUnknown flag: '--capabilities'.Testing
--capabilities; all 7 sample files ingested end to end (7 passed, 0 failed, 0 skipped); the qsv contract regression tests passed (14/14).test_qsv_command_client.py, plus thedescribegpttests intest_ai_suggestions.py; 24 total): CI doesn't run these, and I ran them locally against qsv-client 0.4.0 withckan/config/utils/psycopg2stubbed. All pass, including the failure paths (JSON error, plain-text error, empty stderr, exit 255) and the new too-old-qsv test. The old fixture fails 11 of thedescribegpttests under 0.4.0.🤖 Generated with Claude Code