Repository navigation
build: require qsv 25.0.0 (MINIMUM_QSV_VERSION, Dockerfile.worker, CI) - #349
Merged
Merged
Conversation
qsv 25.0.0 is the first release with structured JSON errors (QSV_ERROR_FORMAT=json, qsv#4765) and --capabilities, which QSVCommand reads through qsv-client; on older qsv both fell back to plain text. Bumps MINIMUM_QSV_VERSION, the Dockerfile.worker QSV_VERSION, and QSV_VER in ci.yml, main.yml and test.yml from 20.1.0 to 25.0.0, plus the README install example and CLAUDE.md. The issue #173 date-inference matrix gives the same types under 25.0.0 as under 20.1.0; its guard is re-pinned to 25.0.x. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qsv 25.0.0 is the first release with the qsv features
QSVCommandreads through qsv-client:QSV_ERROR_FORMAT=json, feat: QSV_ERROR_FORMAT=json and --capabilities for subprocess callers qsv#4765): a failed qsv step reports its error kind and message instead of raw stderr;qsv --capabilities, used for the version check.On older qsv, both fell back to parsing plain text. 25.0.0 also redacts API keys from
describegpt's attribution (dathere/qsv#4766).Changes
MINIMUM_QSV_VERSION20.1.0 → 25.0.0 (BREAKING for operators: DP+ refuses to start on an older qsv; CHANGELOG entry added).Dockerfile.workerQSV_VERSION, andQSV_VERinci.yml,main.ymlandtest.yml→ 25.0.0. Both the gnu and musl 25.0.0 Linux zips containqsvdp.tests/test_qsv_v20_regression.py: the pinned-floor assertion now expects 25.0.0.tests/test_issue_173_date_format_inference.py: the inference matrix was skipped on anything but 20.1.x. Under qsv 25.0.0 every column infers the same type as under 20.1.0 (the two known gaps, epoch ints and DD-MM-YYYY, remain), so the guard is re-pinned to 25.0.x with the matrix unchanged.Testing
tests/test_qsv_v20_regression.py+tests/test_issue_173_date_format_inference.pyagainst the real qsv 25.0.0 binary: 18 passed (previously 17 passed, 1 skipped). Mutation check: flipping one matrix cell fails the matrix test.🤖 Generated with Claude Code