Repository navigation
build: qsv-client >= 0.4.0 - #22
Merged
Merged
Conversation
qsv-client 0.4.0 requires qsv 25.0.0+ (already in the image) and checks `qsv --capabilities` before a client's first run. - QsvVersionError is now a QsvError subclass, so drop it from _QSV_FAILURES and fix the comment. - The fake qsv in the profiling tests answers --capabilities like qsv 25.0.0; the qsvlite test no longer relies on the removed --version/--list fallback. - New test: a qsv older than 25.0.0 makes a profiling pass return None instead of raising. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades to qsv-client 0.4.0.
What changed upstream
qsv --capabilitiesbefore its first command. The Docker image already ships qsv 25.0.0 (build: qsv 25.0.0 in the image, qsv-client >= 0.3.0 #21).QsvVersionErroris now aQsvErrorsubclass.--version/--listfallback is gone.Changes here
pyproject.toml/uv.lock:qsv-client>=0.4.0.qsv_profiling.py: drop the now-redundantQsvVersionErrorfrom_QSV_FAILURESand fix the stale comment.test_qsv_profiling.py: the fake qsv answers--capabilitieslike qsv 25.0.0 (6 tests failed without it). The qsvlite/no-describegpt test now uses capabilities instead of the removed fallback. Added a test that a qsv older than 25.0.0 makes a pass returnNoneinstead of raising.Note for local dev
A local qsv older than 25.0.0 now makes every profiling pass fail with
QsvVersionError. Upgrade qsv before pulling this.Testing
uv run pytest: 1024 passed, 2 skipped.ruff checkis clean.🤖 Generated with Claude Code