Skip jextract binding generation by default - #716
Open
ashkrisk wants to merge 1 commit into
Open
Conversation
Modify the process by which maven builds the native SIMD library so that bindings are not generated by default. The existing build process re-generates the bindings on each build as long as jextract is in the path. This can cause issues since the jextract version on the system may not match the jextract version used to generate the checked-in bindings. This not only creates noise in the git working tree, but can also cause build errors since newer jextract releases may use language features from newer JDKs. Changes made: - Split the `jextract_vector_simd.sh` script into two scripts, one which builds the native library and the other which generates bindings using jextract. - The binding generation script is added to the pom, but is skipped by default. - Warn if the jextract version found doesn't match the expected jextract version. - In case multiple versions of jextract are present on the system, you can specify which one to use via an environment variable.
ashkrisk
requested review from
MarkWolters,
jshook and
tlwillke
as code owners
August 25, 2026 16:09
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify the process by which maven builds the native SIMD library so that bindings are not generated by default.
Motivation
The existing build process re-generates the bindings on each build as long as jextract is in the path. This can cause issues since the jextract version on the system may not match the jextract version used to generate the checked-in bindings. This not only creates noise in the git working tree, but can also cause build errors since newer jextract releases may use language features from newer JDKs.
Changes made:
jextract_vector_simd.shscript into two scripts, one which builds the native library and the other which generates bindings using jextract.Additional information
The attached release notes describe the expected usage pattern.
Example of the kind of error that I observed on my system which had jextract 25 installed: