ZCU-PUB/Update author redirect based on configuration#1298
Open
Kasinhou wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes ORCID-author authority rendering configurable, allowing author names to either link to ORCID profiles or to the existing browse-by-author page while keeping an ORCID icon link available.
Changes:
- Adds ORCID utility helpers for loading configuration, detecting ORCID authority values, and building profile URLs.
- Updates the plain-text metadata representation component/template to support
orcid.author.link-target. - Adds the ORCID link title translation and styling for standalone ORCID icon links.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/app/shared/utils/orcid-author.util.ts |
Adds ORCID config loading, authority detection, and URL construction helpers. |
src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.ts |
Loads ORCID-related config and exposes helpers for ORCID/browse rendering. |
src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.html |
Adds configurable ORCID-vs-browse author link rendering. |
src/app/shared/object-list/metadata-representation-list-element/plain-text/plain-text-metadata-list-element.component.scss |
Styles the standalone ORCID icon link. |
src/assets/i18n/en.json5 |
Adds English ORCID profile link title. |
src/assets/i18n/cs.json5 |
Adds Czech ORCID profile link title. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
BE PR: dataquest-dev/DSpace#1324
Authors with ORCID have icon next to name (redirect to orcid url). When clicking on author name, you can configure if it will redirect to orcid url or default browse as it was before.
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review