UFAL/Separate CLARIN license payload from sections.license#1292
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the CLARIN license submission step to persist the selected CLARIN license under its own section payload (sections.clarin-license) instead of using the legacy top-level /license field, aligning with the goal of keeping CLARIN and CC license data separate.
Changes:
- Updated the JSON-PATCH operation to write the selected CLARIN license name to
/sections/<sectionId>/name. - Added a unit test asserting the generated PATCH request targets
/sections/clarin-license/name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/app/submission/sections/clarin-license-resource/section-license.component.ts |
Routes license updates through the section-scoped PATCH path to keep CLARIN payload separate. |
src/app/submission/sections/clarin-license-resource/section-license.component.spec.ts |
Adds regression test verifying the new PATCH path and value. |
…cense to ClarinDataLicense, and clean up comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Issue: https://github.com/dataquest-dev/dspace-customers/issues/617
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review