[Port to dtq-dev] Add 'Add URL bitstream' feature to workspace items#1269
Open
kosarko wants to merge 2 commits into
Open
[Port to dtq-dev] Add 'Add URL bitstream' feature to workspace items#1269kosarko wants to merge 2 commits into
kosarko wants to merge 2 commits into
Conversation
Introduce an "Add bitstream from URL" action for workspace items: add a conditional button and modal UI to input a file URL and optional name. Implement component support using ScriptDataService to call the 'file-downloader' script, manage processing state, show success/error notifications, and navigate to the created process detail on success. Add related unit tests (scriptDataService stub, UI visibility, invocation params, success/failure flows) and update English and Czech i18n strings. (cherry picked from commit 65c3a5c)
There was a problem hiding this comment.
Pull request overview
Ports the “Add URL bitstream” workflow action to dtq-dev, enabling users to attach a new bitstream to a workspace item by invoking the backend file-downloader script with user-provided parameters.
Changes:
- Added an “Add bitstream from URL” action button and modal UI in workspace item actions.
- Implemented script availability gating + invocation logic (with notifications and redirect to the created process).
- Added EN/CS i18n strings for the new button + modal.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/assets/i18n/en.json5 |
Adds new English translations for the URL-bitstream action + modal. |
src/assets/i18n/cs.json5 |
Adds new Czech translations for the URL-bitstream action + modal. |
src/app/shared/mydspace-actions/workspaceitem/workspaceitem-actions.component.ts |
Adds script-availability check and invokes file-downloader with URL/name parameters. |
src/app/shared/mydspace-actions/workspaceitem/workspaceitem-actions.component.spec.ts |
Adds unit tests covering visibility, invocation parameters, navigation, and notifications. |
src/app/shared/mydspace-actions/workspaceitem/workspaceitem-actions.component.html |
Adds the new action button and the “Add bitstream from URL” modal markup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of ufal#110 by @amadulhaxxani to
dtq-dev.