ZCU-DATA/Script to assign authority from dc.identifier.orcid#1317
Merged
milanmajchrak merged 3 commits intoMay 26, 2026
Conversation
3 tasks
There was a problem hiding this comment.
Pull request overview
Adds a new DSpace script (and Spring wiring) to assign ORCID-based authority values to dc.contributor.author by matching author names stored in dc.identifier.orcid, plus integration tests and related configuration updates.
Changes:
- Register a new CLI/REST script:
orcid-authority-assign(configuration beans in both API + REST script registries). - Implement
OrcidAuthorityAssignscript and add an integration test suite covering multiple matching scenarios. - Update ORCID configuration/exposed REST properties (notably
orcid.domain-url).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| dspace/config/spring/rest/scripts.xml | Registers the new script for REST script execution. |
| dspace/config/spring/api/scripts.xml | Registers the new script for CLI/API script execution. |
| dspace/config/modules/rest.cfg | Exposes orcid.domain-url via REST config endpoint. |
| dspace/config/modules/orcid.cfg | Changes default ORCID domain URL (but currently mixes sandbox/prod endpoints). |
| dspace-api/src/main/java/org/dspace/orcid/script/OrcidAuthorityAssignScriptConfiguration.java | Adds ScriptConfiguration for the new script. |
| dspace-api/src/main/java/org/dspace/orcid/script/OrcidAuthorityAssign.java | Implements ORCID authority assignment logic. |
| dspace-api/src/test/java/org/dspace/orcid/script/OrcidAuthorityAssignIT.java | Adds integration tests for authority assignment behavior. |
| dspace-api/src/test/data/dspaceFolder/config/spring/api/scripts.xml | Ensures script is available in test Spring script registry. |
| dspace-api/src/test/data/dspaceFolder/config/local.cfg | Sets ORCID sandbox domain for tests. |
Comments suppressed due to low confidence (1)
dspace/config/modules/orcid.cfg:19
orcid.domain-urlis switched to the production UI domain, butorcid.api-url/orcid.public-urlremain pointed at the sandbox APIs. This mix of prod/sandbox endpoints will break OAuth flows or API calls depending on which URLs are used. Align these endpoints to the same environment (all sandbox or all production).
orcid.domain-url= https://orcid.org
orcid.authorize-url = ${orcid.domain-url}/oauth/authorize
orcid.token-url = ${orcid.domain-url}/oauth/token
orcid.api-url = https://api.sandbox.orcid.org/v3.0
orcid.public-url = https://pub.sandbox.orcid.org/v3.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Cherry-pick from #1299
Manual Testing (if applicable)
Copilot review