Skip to content

ZCU-DATA/Script to assign authority from dc.identifier.orcid#1317

Merged
milanmajchrak merged 3 commits into
customer/zcu-datafrom
zcu-data/update-authority-process
May 26, 2026
Merged

ZCU-DATA/Script to assign authority from dc.identifier.orcid#1317
milanmajchrak merged 3 commits into
customer/zcu-datafrom
zcu-data/update-authority-process

Conversation

@Kasinhou
Copy link
Copy Markdown

@Kasinhou Kasinhou commented May 20, 2026

Problem description

Cherry-pick from #1299

Manual Testing (if applicable)

Copilot review

  • Requested review from Copilot

@Kasinhou Kasinhou self-assigned this May 20, 2026
@Kasinhou Kasinhou requested a review from milanmajchrak May 20, 2026 15:38
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new DSpace script (and Spring wiring) to assign ORCID-based authority values to dc.contributor.author by matching author names stored in dc.identifier.orcid, plus integration tests and related configuration updates.

Changes:

  • Register a new CLI/REST script: orcid-authority-assign (configuration beans in both API + REST script registries).
  • Implement OrcidAuthorityAssign script and add an integration test suite covering multiple matching scenarios.
  • Update ORCID configuration/exposed REST properties (notably orcid.domain-url).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
dspace/config/spring/rest/scripts.xml Registers the new script for REST script execution.
dspace/config/spring/api/scripts.xml Registers the new script for CLI/API script execution.
dspace/config/modules/rest.cfg Exposes orcid.domain-url via REST config endpoint.
dspace/config/modules/orcid.cfg Changes default ORCID domain URL (but currently mixes sandbox/prod endpoints).
dspace-api/src/main/java/org/dspace/orcid/script/OrcidAuthorityAssignScriptConfiguration.java Adds ScriptConfiguration for the new script.
dspace-api/src/main/java/org/dspace/orcid/script/OrcidAuthorityAssign.java Implements ORCID authority assignment logic.
dspace-api/src/test/java/org/dspace/orcid/script/OrcidAuthorityAssignIT.java Adds integration tests for authority assignment behavior.
dspace-api/src/test/data/dspaceFolder/config/spring/api/scripts.xml Ensures script is available in test Spring script registry.
dspace-api/src/test/data/dspaceFolder/config/local.cfg Sets ORCID sandbox domain for tests.
Comments suppressed due to low confidence (1)

dspace/config/modules/orcid.cfg:19

  • orcid.domain-url is switched to the production UI domain, but orcid.api-url / orcid.public-url remain pointed at the sandbox APIs. This mix of prod/sandbox endpoints will break OAuth flows or API calls depending on which URLs are used. Align these endpoints to the same environment (all sandbox or all production).
orcid.domain-url= https://orcid.org
orcid.authorize-url = ${orcid.domain-url}/oauth/authorize
orcid.token-url = ${orcid.domain-url}/oauth/token
orcid.api-url = https://api.sandbox.orcid.org/v3.0
orcid.public-url = https://pub.sandbox.orcid.org/v3.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dspace/config/modules/orcid.cfg Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@milanmajchrak milanmajchrak merged commit fa5d777 into customer/zcu-data May 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants