Skip to content

FigpackRef.load()/show() broken on DataJoint 2.3 (remote get_folder AttributeError; file branch caches None) #3

Description

@dimitri-yatsenko

FigpackRef.load() (and therefore show()) is non-functional against DataJoint 2.3, on both storage paths. Surfaced during review of #2, which intentionally left load() untouched to keep scope tight.

Defects

  1. Remote branch calls a method that no longer exists. ref.py load() calls self._backend.get_folder(self.path, str(local_path)), but DataJoint 2.3's StorageBackend has no get_folder (verified against datajoint/storage.py on 2.3.x — the folder download idiom is now backend.fs.get(full_path, dst, recursive=True), as used by serve_under). Any non-file store raises AttributeError.

  2. File branch caches a non-view. The file branch caches figpack.view_figure(local_path). Per figpack ≥ 0.3, view_figure() serves the figure over HTTP and returns None rather than reconstructing a FigpackView, so load() returns/caches None and show() does not display a reconstructed view.

Because both load() and show() are featured in the class docstring and the package README/__init__ example (ref.show()), the advertised primary API currently fails.

Proposed fix

Refs #2.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions