feat: implement .jitCode() support for Assertion actions#2170
Open
rafal-hawrylak wants to merge 1 commit into
Open
feat: implement .jitCode() support for Assertion actions#2170rafal-hawrylak wants to merge 1 commit into
rafal-hawrylak wants to merge 1 commit into
Conversation
- Add `jit_code` field to the `Assertion` message in `protos/core.proto` - Fix missing protobuf imports and configuration in `protos/BUILD` - Introduce `JitAssertionResult` type alias and `jitCode` method to `Assertion` builder (`core/actions/assertion.ts`) - Add strictly typed `jitContextable` parameter to `Session.sqlxAction` in `core/session.ts` - Update assertion `compile()` to handle `jitCode` execution bypassing standard string evaluation - Parse and apply `jitContextable` safely for assertions in `core/session.ts` - Add unit test coverage in `core/main_test.ts` to verify compilation output
rafal-hawrylak
requested review from
Ceridan,
andrzej-grudzien,
apilaskowski and
ikholopov-omni
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jit_codefield to theAssertionmessage inprotos/core.protoJitAssertionResulttype alias andjitCodemethod toAssertionbuilder (core/actions/assertion.ts)jitContextableparameter toSession.sqlxActionincore/session.tscompile()to handlejitCodeexecution bypassing standard string evaluationjitContextablesafely for assertions incore/session.tscore/main_test.tsto verify compilation output