feat: add .preOps() and .postOps() support to Assertion action#2169
Closed
rafal-hawrylak wants to merge 1 commit into
Closed
feat: add .preOps() and .postOps() support to Assertion action#2169rafal-hawrylak wants to merge 1 commit into
rafal-hawrylak wants to merge 1 commit into
Conversation
This update brings the Assertion action on par with Table and View by introducing support for pre-operations and post-operations. - Updated `dataform.proto` (via `core.proto` and `configs.proto`) to include `pre_ops`/`post_ops` for `Assertion` and `pre_operations`/ `post_operations` for `AssertionConfig`. - Enhanced `core/actions/assertion.ts` with `contextablePreOps` and `contextablePostOps` arrays. - Exposed `.preOps()` and `.postOps()` methods on both `Assertion` builder and `AssertionContext`. - Added test coverage in `core/main_test.ts` to ensure operations are compiled correctly for assertions.
rafal-hawrylak
requested review from
andrzej-grudzien,
apilaskowski,
fafsdafsafs and
ikholopov-omni
and removed request for
a team
Contributor
|
Assertions work in a way that query fails in case of a failed assertion condition. So not sure how |
Collaborator
Author
Right, that is not the thing we need. |
Collaborator
Author
|
Not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update brings the Assertion action on par with Table and View by introducing support for pre-operations and post-operations.
dataform.proto(viacore.protoandconfigs.proto) to includepre_ops/post_opsforAssertionandpre_operations/post_operationsforAssertionConfig.core/actions/assertion.tswithcontextablePreOpsandcontextablePostOpsarrays..preOps()and.postOps()methods on bothAssertionbuilder andAssertionContext.core/main_test.tsto ensure operations are compiled correctly for assertions.