feat: add getContents() for reading external markdown files into table descriptions pr fix#2164
Open
AmmanuelT wants to merge 10 commits into
Open
feat: add getContents() for reading external markdown files into table descriptions pr fix#2164AmmanuelT wants to merge 10 commits into
AmmanuelT wants to merge 10 commits into
Conversation
…n on getContents to include limits
Contributor
|
/gcbrun |
kolina
approved these changes
May 10, 2026
| const callerFile = utils.getCallerFile(this.rootDir); | ||
| const callerDir = Path.dirName(callerFile); | ||
| const resolvedPath = Path.normalize(Path.join(callerDir,filePath)); | ||
| const absolutePath = Path.separator + Path.normalize(Path.join(this.rootDir, resolvedPath)); |
Contributor
There was a problem hiding this comment.
Do we need to prepend Path.separator here?
Contributor
Author
There was a problem hiding this comment.
The join helper strips the separator from the beginning of the absolutePath, so the start with root wouldn't work because of the missing separator.
| public getContents(filePath: string): string { | ||
| const callerFile = utils.getCallerFile(this.rootDir); | ||
| const callerDir = Path.dirName(callerFile); | ||
| const resolvedPath = Path.normalize(Path.join(callerDir,filePath)); |
Contributor
There was a problem hiding this comment.
If we call Path.normalize below anyway, here it may not be needed?
Contributor
Author
There was a problem hiding this comment.
Good point, it is redundant. It has been removed. Thank you for pointing this out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1723
Re-Opening Pr #2138, which failed once merged as a node module was being used. It has now been removed.
Changes: