Repository navigation
Conversation
A changed list (resource monitor triggers, network policy IPs, hybrid table indexes) rendered as one table cell. Past 60 characters the cell collapsed to '<1 line, N chars>', so the plan hid what changed. Show one item per row, before and after side by side, with dict items as key: value pairs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
snowcap plannow shows a changed list property one item per row, with the before and after values side by side. A dict item shows askey: valuepairs. A non-list value renders as before.Why
The plan rendered a changed list as one table cell. Past 60 characters, the cell collapsed to
<1 line, N chars>. The reviewer could see that something changed but not what changed. A one-word change to a resource monitor trigger (#86) looked like this:With this change:
This applies to every list property, for example
allowed_ip_liston network policies andindexeson hybrid tables. Each item shows in full. Only a multiline item still collapses, because the table cannot show a newline.Items pair by position. If an item is inserted mid-list, the rows after it differ too. This keeps the change small. Lists that Snowcap already sorts (for example resource monitor triggers in #86) line up item by item.
Tested
tests/test_blueprint.py::test_plan_text_shows_each_item_of_a_changed_list(network policy IPs; hybrid table indexes with an item longer than 60 chars)pytest tests --ignore=tests/integrationmake lintsnowcap planagainst a live account with one changedACCOUNT_RMtrigger (on top of #86)