Feat/test azure filestore metadata#1234
Merged
jschoedl merged 119 commits intoJun 18, 2026
Merged
Conversation
…attributes add sort by schema.name and properties by ordinal_position
…/datacontract-cli into feat/snowflake_importer
…, defaultValue, Roles in server
…/datacontract-cli into feat/snowflake_importer_bhn
added tests and key authentication
…UnPivotCustomProperties Add Import feature
Feat/snowflake importer
…into feat/powerbi_importer # Conflicts: # README.md # datacontract/command_import.py # datacontract/imports/importer.py # datacontract/imports/importer_factory.py
Feat/powerbi importer
…stomPropertiesPivot
…Pivot Feat/export excel custom properties pivot
jschoedl
added a commit
to dmaresma/datacontract-cli
that referenced
this pull request
Jun 10, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jschoedl
added a commit
that referenced
this pull request
Jun 13, 2026
* init snowflake importer * ruff format fix * add documentation * improve export query and fix ordered columns position, disable empty attributes add sort by schema.name and properties by ordinal_position * inject account in server.account * improve connector login * ruff * rename customProperties ordinalPosition * refactor snowflake-db and add test_import_snowflake * ruff lint applied * typo during refactor * force string, char as varchar for physicalType * add columns tags, customProperties: precisition, scale, autoIncrement, defaultValue, Roles in server * refactor * turn snowflake tags as str Key=Value array * added tests and key authentication * add DMF as quality (schema & properties) based on last results * merged upstream changes * removed temp file * fix bug * typo on description * test success * double-quoted schema identifiers and authenticator documentation * ruff format * detect snowflake_authenticator in env. variable * ruff format * remove_unexpect_characters * remove schema * fix test failure * implement server mandatory properties * remove typo quote * refactor use of the odcs_helper (improved) Co-authored-by: Copilot <copilot@github.com> * remove un used package * linting format and fixes Co-authored-by: Copilot <copilot@github.com> * add property sort by ordinal position and schema sort by name Co-authored-by: Copilot <copilot@github.com> * run ruff format fix * test fix * improve physicalType extraction * physicalType ruff format 'n check * autoincrement wrong physicaltype format, Tags issues * fix reinject unique property when IDENTITY found * physicalType drive the logicalType using sql import mapping * use custom --schema option to align with v0.12.0 * use snake_case for variable names * typos & ruff format * Snowflake environment variable table updated * refactor based on comments * refactor * ruff applied * test fix * refactor with github copilot * init * add change log * change pbix into pbit * init * datacontract binding schema properties on the azure blob metadata * run ruff format and ruff check --fix * move references from customproperties to relationship object, add id and expression into transformationLogic * improve add relationship * format fix and comment changes applied * fix test sequence * pass the test * refactor * format fix * lib dependency fix * remove docstring * rfc pending * init * slightly modify fixture & README * add template schema's properties customProperties start * changelog update * Update pyproject.toml Co-authored-by: Jakob Schödl <jakob.schoedl@mailbox.org> * Update pyproject.toml Co-authored-by: Jakob Schödl <jakob.schoedl@mailbox.org> * refactor, add schema logicalType (blob as experiment) * init * error code typo * refactor format for powerbi-semantic-model * format and ruff check * undo changes that are already in #1234 and #1268 * refactor: polish Power BI importer naming, types, and tests Rename ImportFormat.powerbi → powerbi_semantic_model and PowerBIImporter → PowerBiImporter for naming consistency, modernize type hints to builtin generics, fix invalid from_table.name in relationship wiring, and tighten the test suite (add list-form DAX coverage, drop redundant tests). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * improve readme powerbi instruction * improve powerbi pbit (.zip) import test * normalize schema name everywhere * update changelog and readme --------- Co-authored-by: Bodo Huesemann <bhuesemann@users.noreply.github.com> Co-authored-by: Jochen Christ <jochen.christ@entropy-data.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Jakob Schödl <jakob.schoedl@entropy-data.com> Co-authored-by: Jakob Schödl <jakob.schoedl@mailbox.org> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…into fork/dmaresma/feat/test_filestore_metadata
Contributor
Author
|
Wow @jschoedl thanks a lot. |
…ection errors - Filter blob schemas by schema_name so --schema-name limits what runs (datacontract#1234) - Thread check_categories through so --checks schema/quality filters per-check - Classify connection vs auth failures in list_blobs with actionable messages - Add end-to-end DataContract.test() test guarding the wiring against merge loss - Drop redundant _parse_location https unit test Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…issing_env failures Blob schemas (logicalType: blob) are owned by check_azure_blob_file, which validates file metadata. The SQL engine was also generating checks for them, trying to open blobs as DuckDB tables over Azure—which failed with missing_env_DATACONTRACT_AZURE_TENANT_ID when no SPN credentials were set. Blob schemas require no SQL connection, only the blob client. Added _is_azure_blob_schema helper to skip them in create_checks. Extended end-to-end wiring test to catch this regression: assert no ibis checks are generated for a blob contract and the run passes without credentials. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jschoedl
requested changes
Jun 17, 2026
…st_filestore_metadata # Conflicts: # README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #1227
uv run pytest)uv run ruff check --fix && uv run ruff format)