Implement Initial Atlas#352
Open
PauloMFJ wants to merge 22 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several foundational UI components such as Button, CardBase, CardChart, and CardText, along with custom hooks and utility functions. The review feedback highlights critical issues that need to be addressed: action buttons in CardBase must stop pointerDown propagation to prevent interfering with tldraw canvas gestures; several accessibility violations of WCAG 2.2 AA standards exist in the tab and button components due to missing ARIA attributes; and a layout bug in CardText allows the loading skeleton and body to render simultaneously.
nick-nlb
previously approved these changes
Jun 4, 2026
nick-nlb
left a comment
nick-nlb
left a comment
There was a problem hiding this comment.
Thanks for this Paulo!
A couple of comments (one is a nit) but otherwise looks good to go.
beets
previously approved these changes
Jun 4, 2026
nick-nlb
approved these changes
Jun 5, 2026
nick-nlb
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements the initial Atlas — an infinite, tldraw-backed canvas that renders data "cards" laid out on a grid. This establishes the rendering foundation and the component architecture for the app, ahead of wiring up a real data source.