Repository navigation
Conversation
|
Implementation is published on |
[CCR-20260930-001] · reviewer · anthropic/claude-sonnet-5-5→? · high · schema:2Initial review: PR #374 (work item #372)Status: REVIEW_PASSED_AWAITING_CI — head ScopeAccumulated diff FindingsNone.
Acceptance criteria (tests.version=2)
The AC-6 fixture is a copy of the issue body; it does not read the live issue. Security triageNot a sensitive change: the security audit was skipped after triage. The deterministic rule ( Commands executed
UnverifiedFull test suite on this head (timeout, see above); CI on GitHub's runners is the remaining evidence. CI (parallel policy, not waited on)Workflow "Validate package", all Residual risksA prose line in the criteria list that begins with a punctuated bold label ( VerdictNo blocking findings. Pending only the CI gate for the head above. |
Closes #372 — #372
Summary
The criteria parser now treats a punctuated bold label followed by prose, such as
**Tests.** text, as a section boundary. Flat-list validation remains strict. Regression coverage includes the existing standalone label and heading forms, malformed and placeholder criteria, bold markup within criteria, and the unchanged body of #330.Diagnosis
Issue #372 reports that roadmap criteria are rejected when the next section uses an inline bold label. Reproduction before the fix:
read_criteria("github", "datacas/code-cycle-toolkit", "330")returnedneeds_refinement: criteria must be a flat Markdown list. The cause matched the issue hypothesis:_SECTIONrecognized only headings and standalone bold labels. The invariant is that every non-section line inside the criteria block must be a flat Markdown list item.The related-item search was widened because this is a bug in a shared parser. It found #159 and closed issue #253 as search candidates; neither shares this parser cause. #330 is the real-world body fixture. Classification:
isolated_defect; decision:implement.Work units
WU-1scripts/verification_plan.py,tests/test_verification_plan.py,tests/fixtures/issue-330.md,docs/verification.mdCriteriaTestsregression coveragepython3 scripts/validate-package.pypassed; configured full suite exceeded the 10-minute stage limit and is unverified.Verification (agent-reported)
python3 -m unittest discover -s tests— timed out after the 10-minute limit and was stopped (exit 130); not verified on the final head.python3 scripts/validate-package.py— passed (exit 0): 16 skills validated and shared sections/manifests aligned.python3 -m unittest— exited 0 but ran 0 tests; this is not evidence for the acceptance criteria.The local run uses the repository checkout and dispatch environment; CI will run on GitHub's hosted runners with its own environment. Code-host checks will be reported for the pushed head once read.