Repository navigation
Conversation
|
Implemented #329 at Native plan execution, schema-25 history, verification-only recovery, conditional rereview and Hotfix proof requirements are implemented. The six owning documentation pages are updated. Agent-reported local evidence:
The full suite has one existing skip. Boundary coverage invokes the real CLI with valid and invalid arguments, installs the runtime with fake agent binaries, and exercises detached verification clones. The tests use disposable Git repositories and SQLite databases with explicit fixture identities, without relying on global Git credentials. Live model dispatch and Windows execution were not performed locally. BasedPyright comparison against the committed baseline reports 172 existing errors and no introduced errors in the affected runtime modules. Checks of this HEAD, read once under the parallel CI policy:
Routing: profile |
Initial review — #371
|
| Command | Exit | Observed |
|---|---|---|
python3 scripts/validate-package.py |
0 | VALID: 16 skills (7 cycle, 9 supporting), shared sections in sync, cross-agent manifests aligned |
python3 -m unittest discover -s tests |
0 | Ran 2121 tests in 392.763s — OK (skipped=1) |
python3 -m unittest |
0 | Ran 0 tests: default discovery from the repository root finds no tests. This configured prefix verifies nothing on its own. |
The findings come from code inspection plus git grep (REV-001, REV-002, REV-004). REV-001 is also backed by the changed installed-cycle tests, which pass with the new stop. REV-003 was not reproduced at runtime, because this read-only stage cannot add a test.
Unverified
- Live model dispatch, and whether a real reviewer emits
security_audit_ranfrom the prompt suffix alone. Not executed; this needs live agents. - Windows execution: covered only by CI.
CI (read once; parallel policy)
| Check | State |
|---|---|
| Skills, manifests, and Bash installer | pass |
| Windows test shard (windows-1) | pass |
| Windows test shard (windows-2) | pass |
| Windows test shard (windows-3) | pending |
| Windows test shard (windows-4) | pass |
The cycle's CI gate decides on the pending shard.
Residual risks
- Every new live behaviour, including Full, Hotfix,
verified_change, verification-only resume and the security barrier, is proven only with fake agents. - Each dispatch now appends one or two plan revisions. The
cycle_execution_planstable grows with every stage. - When work-item criteria change, the old items are restored as opaque
AC-nplaceholders and the new criteria are appended. The old prose is not recoverable for the agent.
Verdict
CHANGES_REQUESTED: blocking findings REV-001 and REV-002.
Resolution — #371Status: [CCR-20261030-001] · senior_reviewer · anthropic/claude-opus-5-5→? · high · schema:2[CCT-20261030-001] · deep_coder · openai/gpt-6.1-sol→? · high · triaged:34b5a0ccbc793af791e393549174563002f563ee · schema:2All four findings were classified [REV-001] · medium · resolved · valid · blocks:yes — The review result key
|
| Command | Exit | Observed |
|---|---|---|
python3 -m unittest tests.test_run_cycle.NativeExecutionPlanTests tests.test_execution_profiles |
0 | 50 tests passed, including real CLI subprocess and disposable verification-clone coverage |
python3 -m unittest tests.test_validate_package tests.test_run_cycle.NativeExecutionPlanTests tests.test_execution_profiles |
0 | 121 tests passed after the validator update |
python3 scripts/validate-package.py |
0 | 16 skills valid; shared sections and cross-agent manifests aligned |
python3 -m unittest discover -s tests |
0 | 2,122 tests in 282.024 seconds; OK, one existing skip |
python3 -m unittest |
0 | 0 tests discovered; no coverage credited |
basedpyright scripts/cycle_loop.py scripts/cycle_session.py scripts/execution_profiles.py --outputjson |
1 | 3 existing errors; not a clean type-check pass |
python3 "$TMPDIR/typecheck.py" |
0 | Same affected-file check including scripts/validate-package.py against disposable reviewed-baseline copies: baseline 6 error diagnostics, current 6, introduced 0; both underlying type-check runs exit 1 |
git diff --check |
0 | No whitespace errors |
The first full-suite run found one validator regression in 2,122 tests; its outdated literal matcher was corrected and the suite rerun. The baseline comparison reports no introduced errors; existing diagnostics remain. No unrelated diagnostics were changed. The tests use disposable repositories/databases and fixture identities rather than GitHub write credentials or global Git identity. Live model dispatch and Windows execution were not run locally; one existing suite skip remains.
Post-fix review and security
Selected delta base: 34b5a0ccbc793af791e393549174563002f563ee, the runtime-supplied trusted review receipt. Ancestor verification succeeded. The delegated cc-code-review read the complete updated 534-line fix delta and returned no P0–P3 findings. This pass does not approve the PR or replace accumulated rereview.
Security triage: no deterministic path/label trigger; reviewer judgement requested an audit because the fix changes security completion reporting and cycle completion. The delegated cc-security-review found no confirmed or new potential vulnerabilities. The omitted-audit barrier remains fail-closed and no permissions, publication boundaries, credentials, dependencies or stored-data projections were weakened. Audit completion remains agent-reported.
Checks of the uploaded head
Read once under the parallel CI policy with gh pr view 371 --repo datacas/code-cycle-toolkit --json headRefOid,statusCheckRollup:
- HEAD:
dcd36fc270c62c0988418bb8c4a1aa2e8df9443f(matches the uploaded commit). - Passed: 0; failed: 0; pending: 0; registered items: 0.
- GitHub returned an empty rollup at this read. This is not a CI pass or evidence that the repository has no configured workflows. No polling, waiting, or in-stage CI fix round was performed; the cycle's CI gate owns subsequent results.
Rereview — #371
|
| Command | Exit | Observed |
|---|---|---|
python3 -m unittest discover -s tests |
0 | Ran 2122 tests in 230.433s — OK (skipped=1) |
python3 scripts/validate-package.py |
0 | VALID: 16 skills (7 cycle, 9 supporting), shared sections in sync, cross-agent manifests aligned |
python3 -m unittest |
0 | Ran 0 tests: default discovery from the repository root finds no tests, so this configured command verifies nothing on its own |
python3 -m unittest -v with the four focused regressions for REV-001 and REV-003 |
0 | Ran 4 tests — OK |
Unverified
- Live model dispatch, including whether a real reviewer emits
security_audit_ranfrom the updated skill contract. That needs live agents. - Windows execution, which only CI covers.
CI (read once; parallel policy)
| Check | State |
|---|---|
| Skills, manifests, and Bash installer | pending (in progress) |
| Windows test shard (windows-1) | pending (in progress) |
| Windows test shard (windows-2) | pending (in progress) |
| Windows test shard (windows-3) | pending (in progress) |
| Windows test shard (windows-4) | pending (in progress) |
Passed 0, failed 0, pending 5 for dcd36fc. The cycle's CI gate decides on these checks.
Residual risks
- Every new live behaviour is still proven only with fake agents: Full, Hotfix,
verified_change, verification-only resume and the security barrier. - The pre-existing comment at
scripts/cycle_dispatch.py:520("Resumes cannot recover criteria revisions until Execute and replan native cycles under mandatory policy gates #329") is outside the diff but now stale. cycle_execution_plansgains one or two revisions per dispatch.
Verdict
REVIEW_PASSED_AWAITING_CI. No open finding blocks approval; REV-005 is blocks:no. Merge readiness waits for the required checks of dcd36fc, and a human owns the merge.
ORCHESTRATION_RESULT (JSON)
ORCHESTRATION_RESULT
{"skill":"cc-rereview","status":"REVIEW_PASSED_AWAITING_CI","issue_provider":"github","issue_id":"329","code_host":"github","change_request_id":"371","change_request_url":"https://github.com/datacas/code-cycle-toolkit/pull/371","pr_number":371,"issue_number":329,"previous_reviewed_head_sha":"34b5a0ccbc793af791e393549174563002f563ee","reviewed_head_sha":"dcd36fc270c62c0988418bb8c4a1aa2e8df9443f","head_sha":"dcd36fc270c62c0988418bb8c4a1aa2e8df9443f","security_audit_ran":true,"review_run_id":"CCR-20261030-002","reviewer":{"profile":"senior_reviewer","provider":"anthropic","model_requested":"claude-opus-5-5","model_resolved":null,"effort":"high"},"verified_findings":[{"id":"REV-001","severity":"medium","blocks_approval":true,"status":"resolved","disposition":"valid"},{"id":"REV-002","severity":"medium","blocks_approval":true,"status":"resolved","disposition":"valid"},{"id":"REV-003","severity":"medium","blocks_approval":false,"status":"resolved","disposition":"valid"},{"id":"REV-004","severity":"low","blocks_approval":false,"status":"resolved","disposition":"valid"}],"new_findings":[{"id":"REV-005","severity":"low","status":"open","disposition":"-","blocks_approval":false,"path":"docs/review-cycle.md","line":394}],"blocking_findings":[],"checks":{"head_sha":"dcd36fc270c62c0988418bb8c4a1aa2e8df9443f","passed":0,"failed":0,"pending":5},"blocking":false}
END_ORCHESTRATION_RESULT
Execute native cycles from the resolved policy plan, preserve verification obligations across revisions, and stop unverified required checks from producing merge readiness.
Closes #329
Work item: #329
Diagnosis
Feature request; decision:
implement. The existing plan contracts describe policy, but the live CLI rejects non-standard execution and the driver follows a fixed stage loop. Check histories are in-memory, ordinary resolution repeats rereview without comparing HEADs, and there is no durable verification-only resume. No defect reproduction applies to this feature request; the existing driver and contract tests establish the integration gap.Related work was searched by execution-plan and verification terms, including closed work and merged changes. #327/#328 and PRs #361/#362 provide the plan contracts; #290/PR #366 provides per-check evidence; #189/PR #369 provides the existing explicit driver loop. #259 and #261 are closed security dependencies. #330 owns supervised Orca integration and remains separate. The change extends the existing loop, gates and history store rather than introducing another workflow engine.
Behavior
verification_unverifiedwhen required evidence is missing; generic CI cannot substitute for it.cc-verifydispatch, retaining completed evidence and a valid clean review. Reconcile changed policies or partial history before reusing evidence.Work units
scripts/cycle_plan.py, driver/history/contracts/permissions/schema modules, runtime manifest, six owning docs pagesVerification
Agent-reported local evidence:
python3 scripts/validate-package.pypython3 -m unittest discover -s testspython3 -m unittest tests.test_run_cycle.NativeExecutionPlanTests tests.test_verification_plan tests.test_execution_planThe full suite has one existing skip. Boundary coverage invokes the real CLI with valid and invalid arguments, installs the runtime with fake agent binaries, and exercises detached verification clones. The tests use disposable Git repositories and SQLite databases with explicit fixture identities, without relying on global Git credentials. Live model dispatch and Windows execution were not performed locally. BasedPyright comparison against the committed baseline reports 172 existing errors and no introduced errors in the affected runtime modules.
Documentation
The prior contract-only behavior was already documented. This PR updates the owning pages in
docs/execution-plan.md,docs/verification.md,docs/workflows.md,docs/review-cycle.md,docs/telemetry.mdanddocs/configuration.mdin the same change. No README entry point was added or removed.CI policy is
parallel: the implementation stage reads checks of the uploaded HEAD once and leaves pending checks to the cycle's CI gate. Human review and merge remain required.