fix nested config items in codex app

src/ucode/codex_config.py

@@ -3,19 +3,34 @@
 from __future__ import annotations
 
 import tomlkit
+from tomlkit.items import Item
 
+type TomlValue = str | int | float | bool | list[TomlValue] | dict[str, TomlValue]
 
-def _toml_value(value: str | int | float | bool | list[object] | dict[str, object]) -> str:
+
+def _toml_item(value: TomlValue) -> Item:
+    """Convert nested Python values without creating regular TOML tables."""
     if isinstance(value, dict):
         item = tomlkit.inline_table()
-        item.update(value)
-        return item.as_string()
-    if isinstance(value, list) and any(isinstance(entry, dict) for entry in value):
-        wrapper = tomlkit.inline_table()
-        wrapper["value"] = value
-        rendered = wrapper.as_string()
-        return rendered.removeprefix("{value = ").removesuffix("}")
-    return tomlkit.item(value).as_string()
+        for key, entry in value.items():
+            item[key] = _toml_item(entry)
+        return item
+    if isinstance(value, list):
+        item = tomlkit.array()
+        for entry in value:
+            item.append(_toml_item(entry))
+        return item
+    if isinstance(value, bool):
+        return tomlkit.item(value)
+    if isinstance(value, int):
+        return tomlkit.item(value)
+    if isinstance(value, float):
+        return tomlkit.item(value)
+    return tomlkit.item(value)
+
+
+def _toml_value(value: TomlValue) -> str:
+    return _toml_item(value).as_string()
 
 
 def codex_config_args(config: dict) -> list[str]:

tests/test_codex_config.py

@@ -1,5 +1,7 @@
 from __future__ import annotations
 
+import tomlkit
+
 from ucode.agents import codex
 from ucode.codex_config import codex_config_args
 
@@ -29,3 +31,30 @@ def test_layers_provider_overrides_without_replacing_user_config(self, monkeypat
         assert "/ai-gateway/codex/v1" in provider_override
         assert 'command = "' in provider_override
         assert '"myprof"' in provider_override
+
+        key, rendered_provider = provider_override.split("=", 1)
+        parsed = tomlkit.parse(f"{key} = {rendered_provider}")
+        provider = parsed["model_providers"]["ucode-databricks"]
+        assert provider["auth"]["timeout_ms"] == 5000
+        assert provider["http_headers"]["User-Agent"].startswith("ucode/0.1.0")
+
+    def test_renders_nested_tables_inside_arrays(self):
+        args = codex_config_args(
+            {
+                "hooks": {
+                    "PreToolUse": [
+                        {
+                            "matcher": "Read",
+                            "hooks": [{"type": "command", "command": "route"}],
+                        }
+                    ]
+                }
+            }
+        )
+
+        assert args[0] == "--config"
+        key, rendered_hooks = args[1].split("=", 1)
+        parsed = tomlkit.parse(f"{key} = {rendered_hooks}")
+        hook = parsed["hooks"]["PreToolUse"][0]
+        assert hook["matcher"] == "Read"
+        assert hook["hooks"][0]["command"] == "route"