feat: databricks tags merge behavior#1340
Open
canbekley wants to merge 4 commits intodatabricks:1.12.latestfrom
Open
feat: databricks tags merge behavior#1340canbekley wants to merge 4 commits intodatabricks:1.12.latestfrom
canbekley wants to merge 4 commits intodatabricks:1.12.latestfrom
Conversation
canbekley
requested review from
benc-db,
sd-db and
tejassp-db
as code owners
canbekley
changed the title
Signed-off-by: Can Bekleyici <can.bekleyici@deepl.com>
canbekley
force-pushed
the
feat/databricks-tags-merge-behaviour
branch
from
13b6cdd to
7efe749
Compare
3 tasks
…tabricks#1407) Here's the trimmed body to paste into PR 1407: ## Summary - Fix concurrency-group collision: manual PR dispatches all shared `workflow-refs/heads/main` and cancelled each other. Group is now target-aware (PR number → `pr_numbers` → `git_ref` → ref). - Replace single `pr_number` input with `pr_numbers` — accepts one PR or comma-separated list for batching (`100,200,300`). - New `prepare` job parses inputs into a JSON target array; the three test jobs fan out via `strategy.matrix.target` with `max-parallel: 2` and `fail-fast: false`. - Artifact names suffixed with the PR id to avoid collisions in batched runs. - Adopt the `setup-python-deps` cache pattern from `main.yml` so matrix cells restore the warm deps cache instead of re-resolving against JFrog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1184
Resolves #1188
Description
defining
databricks_tagson a lower configuration level currently completely replaces/clobbers any tag configuration defined at higher level (e.g. indbt_project.yml). this is very unintuitive for dictionary type configurations and is usually solved with additive dictionary merging behaviour (e.g.meta,tags,grantsetc.).dbt-common implements the
MergeBehaviorenum that can be used to set the meta_data of the dataclass fields in DatabricksConfig, which is handled by the BaseConfig. definingMergeBehavior.Updatefordatabricks_tagsbasically makes it an additive dictionary field.Note:
tblpropertiesconfiguration as well, as those suffer the same limitations at the moment. I could add it in here if you like.Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.