fix(metadata): order getTypeInfo rows by DATA_TYPE - #1680
Merged
Conversation
Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
cathleeny
requested review from
eric-wang-1990,
sreekanth-db,
vikrantpuppala and
vuanhphung
September 8, 2026 23:51
vuanhphung
approved these changes
Sep 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DatabaseMetaData.getTypeInfo()catalogue so theINTERVALrow is emitted with the otherTypes.VARCHARrows, beforeBOOLEAN,DATE, andTIMESTAMP.DATA_TYPEvalues to be nondecreasing.NEXT_CHANGELOG.md.The catalogue is shared by the Thrift and SEA metadata clients, so this fixes both backends without changing any row contents or type mappings. This also allows databricks-driver-test#1413 to replace its known-failure tripwire with the strict JDBC ordering assertion.
Fixes #1661.
Testing
MetadataResultSetBuilderTestandDatabricksDatabaseMetaDataTest).databricks-jdbc-coresuite: 3,640 tests passed, 0 failed, 88 skipped.mvn spotless:check: passed across the full reactor.