Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbe881496b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
⏱ CI timing · Devrun 41074104023 · attempt 2 (wall time includes re-run gap) · 53.0 min (main p50 63.3 min, −10.3 min)
Minutes unless stated; durations exclude queue time unless stated; "max" = longest job in the group. Baseline = median of the last 10 successful runs (Dev: |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
CREATE MATERIALIZED VIEW db2.mv AS SELECT c1 FROM db1.t WHERE 1 = 1. The source still has to be in the same catalog as the MV.mget_database_names_by_idsinstead ofget_db_name_by_id. A dropped database keeps its id-to-name mapping until GC, andget_db_name_by_idstill returns that name. Before this change, dropping the MV's database made every query on the source table fail with UnknownDatabase. MVs in a dropped database are now skipped, the same as dropped MVs.system.materialized_views:list_materialized_views_implnow reads the source database'sDatabaseMetain the same MGET. An MV whose source database is dropped is reported asinvalid = 1instead of0.05_0017_ddl_materialized_view.testcovers creating a cross-database MV, refreshing it, reading it, theinvalidstate afterDROP DATABASEandUNDROP DATABASEon the source database, and querying the source after the MV's database is dropped.fixes: #[Link the issue here]
Tests
Type of change
AI assistance
This change is