Repository navigation
Conversation
5 of 12 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Column::wrap_nullable, with a checked typedNullableColumn::new. Make the inner column and bitmap private, removenew_column/new_unchecked, and migrate consumers to accessors,destructureandmerge_validity. Wrapping an already-nullable column intersects masks without adding a layer; Null columns stay Null. Reject mismatched lengths and invalid Nullable/Null inner types at construction boundaries, including dynamic/generic columns and Arrow conversion.regexp.txtis byte-identical to main and is no longer part of this PR's diff; the regexp golden and partial-evaluation regression tests pass without regeneration.expression/tests/it/nullable.rsandtypes.rsexercises empty/all-valid/all-null/mixed masks, outer context, scalar/column results, output validity intersection, inactive-row errors, TRY wrappers, repeated wrapping, Null columns, legacy normalization and invalid constructors/builders. Add02_0013_nullable_construction.testfor casts, nullable tuple fields and outer joins, for example:1bb457513f685b40aea560b557a59893a493e1b8without rewriting branch history. Preserve main's encoded-dictionary/NDV behavior and existing nullable error-to-null domains, retain this PR's scalar mixed-validity handling, and adapt newly added decimal/encoded/vector-index callers to the private Nullable API. No toolchain updates or Python UDF networking branch changes are included.cargo fmt --all -- --check, andcargo clippy -p databend-common-expression -p databend-common-functions -p databend-common-formats -p databend-common-pipeline-transforms -p databend-storages-common-index -p databend-common-storages-fuse -p databend-query --tests -- -D warningspassed. Refreshed the pipeline integration suite (7 tests), Parquet encoding tests (7 tests) and HTTP serialization tests (15 tests); rebuilt the query binary and executed 51 SQL logic records from the new construction regression plus existing nullable/tuple/try_cast files against an isolated local query node using a temporary HTTP record-checking script. The official sqllogictest runner was not used for this local SQL check. Full-workspace tests and performance benchmarks were not run; no performance claim is made.Tests
Type of change
AI assistance
This change is