Repository navigation
Conversation
1 task done
Contributor
⏱ CI timing · Devrun 40843837115 · attempt 2 (wall time includes re-run gap) · 44.0 min (main p50 43.3 min, +0.7 min)
Minutes unless stated; durations exclude queue time unless stated; "max" = longest job in the group. Baseline = median of the last 10 successful runs (Dev: |
sundy-li
marked this pull request as ready for review
October 29, 2026 08:40
This was referenced Oct 29, 2026
Member
Author
|
Consolidated into #20898 at the author’s request. That branch already contains all prerequisite Databend changes and the final integration-bound HTTP/CONNECT implementation, with no python_udf_allow_network config/CLI or blanket worker override. #20898 targets main directly; this PR must not be merged separately. The worker transport remains in the separate dependency PR datafuse-extras/arrow-udf#5. No code changes or history rewrites were needed for this consolidation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
[query].python_udf_allow_network = false(CLI:--python-udf-allow-network=true) as an administrator-only compatibility exception for existing network-dependent Python script UDFs following feat(query): sandbox Python UDF workers and bound script UDF resources #20830. It is not a SQL setting or UDF option, and does not changeenable_udf_sandboxrouting.cc08c3e538f8347545540020dc289cc498c7d3e5. Dependency PR: feat(python-worker): add host-controlled outbound network policy datafuse-extras/arrow-udf#4 (must land before this PR).bind/listen. Enabling logs a warning. It applies to every Python UDF on the node, is not a destination allowlist, and also exposes internal/loopback destinations subject to deployment egress policy.test_configs_table_basicgolden; affected config/UDF/service cratescargo clippy --tests -- -D warnings; query binary build;cargo fmt --all --check, diff and shell syntax checks. New regression:08_0006_network_policy.shverifies denied INSERT leaves no row, deliberate NULL/error JSON, and absence from SQL settings.requests.get()returns JSON events, ingestion stores actual events, and restarting with the exception disabled revokes access. Temporary services were stopped. Full workspace tests were not run.Tests
Type of change
AI assistance
This change is