Repository navigation
feat(query): support result set spilling - #18679
Merged
Merged
Conversation
sundy-li
reviewed
Sep 5, 2025
sundy-li
reviewed
Sep 5, 2025
sundy-li
reviewed
Sep 5, 2025
forsaken628
force-pushed
the
result-spill
branch
from
September 7, 2025 09:41
5ba34d9 to
0242a0a
Compare
forsaken628
force-pushed
the
result-spill
branch
from
September 10, 2025 04:51
4bdaeac to
8e38064
Compare
Member
|
please update the code synchronization #18709 This PR solves the CI test_private_tasks error |
Collaborator
Author
|
In this PR, the sender writes the spilled page into a file, which the receiver then restores. However, this logic is not very reasonable because the size of the page depends on the transmission layer, which does not necessarily correspond to the spilling mode. In the follow-up, a new spill unit called a "chunk" can be introduced. The sender writes the chunks, which then generates a page from it. |
forsaken628
marked this pull request as ready for review
September 11, 2025 09:05
youngsofun
reviewed
Sep 11, 2025
youngsofun
reviewed
Sep 11, 2025
youngsofun
reviewed
Sep 12, 2025
youngsofun
approved these changes
Sep 12, 2025
Contributor
Docker Image for PR
|
Member
|
Will do some test on prod this weekend. |
Contributor
Docker Image for PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
enable_result_set_spilling, which is turned off by default and is fully compatible with the previous behavior.result_set_spilling_to_disk_bytes_limitto support spilling result set data to local disk.Tests
Type of change
This change is