Skip to content

Gabriel_SQL_Basic_Queries.sql#672

Open
gabrieleb76-bot wants to merge 1 commit intodata-bootcamp-v4:mainfrom
gabrieleb76-bot:main
Open

Gabriel_SQL_Basic_Queries.sql#672
gabrieleb76-bot wants to merge 1 commit intodata-bootcamp-v4:mainfrom
gabrieleb76-bot:main

Conversation

@gabrieleb76-bot
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SQL script is well organized and demonstrates a solid grasp of foundational querying against the Sakila database. The progression from simple retrieval queries to more focused operations using filtering, aggregation, and sorting is logical and easy to follow. Aliasing is used appropriately to improve readability, and constructs like DISTINCT, COUNT(), and ORDER BY are applied correctly. The filtering conditions, including pattern matching with LIKE and numeric constraints, are also implemented accurately. That said, there are a few areas that could be tightened. Using SELECT * is acceptable for exploration, but in a more production-oriented context it would be better to explicitly select only the required columns to improve performance and clarity. There is also a minor issue with duplicate numbering in the comments, which slightly affects readability. Overall, this is a clean and functional set of queries that reflects good SQL fundamentals, with small opportunities to align it more closely with best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants