-
Notifications
You must be signed in to change notification settings - Fork 52
RFC: add support for negative axes in permute_dims #962
Copy link
Copy link
Closed
Labels
API extensionAdds new functions or objects to the API.Adds new functions or objects to the API.RFCRequest for comments. Feature requests and proposed changes.Request for comments. Feature requests and proposed changes.topic: ManipulationArray manipulation and transformation.Array manipulation and transformation.
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
API extensionAdds new functions or objects to the API.Adds new functions or objects to the API.RFCRequest for comments. Feature requests and proposed changes.Request for comments. Feature requests and proposed changes.topic: ManipulationArray manipulation and transformation.Array manipulation and transformation.
Type
Projects
- StatusShow more project fieldsStage 4
Hi there,
I noticed that negative index can not used for permute_dim when using Jax.numpy namespace.
Although documentation about permute_dims did mention that
"axes (Tuple[int, ...]) – tuple containing a permutation of (0, 1, ..., N-1) where N is the number of axes (dimensions) of x"
However, indexing page says api standard compatible with negative indexing.
Right now, I normalized index before calling permute_dims. However, I do hope your team can make it more clear by whatever measurements. For example, just simply Noting out the non-negative requirement, vs using negative index common people will do, if this is made by designing.
By the way, it will be appreciated if you can share your design philosophy since I am working on a project involves array manipulations. Is that because permute_dim is more like an internal function?