Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator tests exercise array-left expressions but do not check scalar-left reflected arithmetic and bitwise operators. This adds cases for the seven reflected arithmetic methods and five reflected bitwise methods, checking dtype, shape, and values against the corresponding Array API functions. The inputs are small and finite, with nonzero divisors, small whole-number exponents, and valid shift counts.
With a temporary wrong-direction
__rtruediv__, the five existingtest_dividecases still pass while the new value assertion fails. The new assertions also detect temporary wrong-direction__rfloordiv__and__rmod__implementations. These checks establish test coverage; they do not indicate a defect in a current backend.Validation: the new test has 115 passing cases with array-api-strict at both API 2025.12 and 2023.12, and 115 with NumPy at the suite's default API version. The related existing operator tests have 15 passing cases, and
flake8 --select Fpasses. API 2021.12 cannot collect even the unchangedtest_dividecase because the existing helpers require__array_namespace_info__. The full suite was not run locally.Refs #460