sdk%fix(zen): follow up base-sdk#32, base-sdk#33 - #34
Conversation
|
Note This pull request has no conflicts! 🎊 🎉 🎊 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (14)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds omit-segment handling to documentation preprocessing, updates related documentation, and adjusts GitHub Actions workflow token handling and path filters. ChangesDocumentation omission
Workflow updates
Sequence Diagram(s)sequenceDiagram
participant DocumentationInput
participant IncludePreprocessor
participant _strip_omitted
participant IncludedFile
DocumentationInput->>IncludePreprocessor: provide source lines
IncludePreprocessor->>_strip_omitted: strip top-level omit segments
IncludePreprocessor->>IncludedFile: expand include directive
IncludedFile-->>IncludePreprocessor: return included lines
IncludePreprocessor->>_strip_omitted: strip omit segments from included lines
_strip_omitted-->>IncludePreprocessor: return filtered lines or ValueError
Merge Risk: ⚪ Minimal · up to Omit-marked documentation content is removed from generated pages while remaining available in source rendering, with validation for malformed segments and fenced content. The workflow updates preserve package trigger behavior and broaden Pages checks for relevant documentation inputs; no current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 38.89% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 1 files. (13 skipped: 13 unsupported.)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Additional Information
Follow-up to sdk%doc: promote
docs/for Zensical namespace, write startup guide, clean up style guide for web publication, make docs guide informative #32Follow-up to sdk%ci: use comment syntax for doc splicing, add
uvlockfile, use for dependency tracking, make CodeQL runner multi-lingual, add symlink linter #33Zensical preprocessing syntax has been updated to support omitting text from the webpage (i.e. meant only for display on GitHub) using the reserved label
omitthat can be used repeatedly (unlike other labels which can define one segment).How Has This Been Tested?
Checklist