Repository navigation
Fix log with separator environment - #245
Merged
daroczig merged 3 commits intoSep 9, 2026
Merged
Conversation
Owner
|
Thanks a ton! Could you please bump the version by appending |
daroczig
approved these changes
Sep 9, 2026
Owner
|
Fantastic, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #244
As described in the linked issue,
log_with_separatorfailed to evaluate expressions when called from inside a function.Using the reprex from the issue, this is now working as expected
I'll be honest: I don't know why adding
envir = parent.frame()to thedo.callcall did the trick because it's the default value of the envir argument. But it's definitely working now.I didn't add a news bullet because I am not sure how you would like to handle development versions. I can add a call to
usethis::use_dev_version()if you want me to.I also added a test for this exact issue. I kept the logic using
expect_outputalthough I think this should be a snapshot.