Repository navigation
Conversation
The reproducibility module is becoming Amber. Package is darnit-amber (keeping the darnit-* convention); framework name is amber (matching the bare-domain convention of openssf-baseline, community-spec, gittuf). - packages/darnit-reproducibility -> packages/darnit-amber - darnit_reproducibility -> darnit_amber, ReproducibilityImplementation -> AmberImplementation - reproducibility.toml -> amber.toml; framework and MCP server name reproducibility -> amber - entry points under darnit.frameworks and darnit.implementations renamed, and the implementation's name property, which is what discovery keys the registry by - docs/design/reproducibility-attestation-system.md -> amber-attestation-system.md - display name now 'Amber - Scientific Reproducibility Checks' Breaking: --framework reproducibility becomes --framework amber, and darnit-reproducibility on PyPI is superseded by darnit-amber. Left alone: specs/ (historical records of what was built at the time) and the audit_reproducibility MCP tool name (renaming it would break agent configs that reference it). Assisted-by: Claude Signed-off-by: Marc-cn <md6796@nyu.edu>
Marc-cn
force-pushed
the
feat/rename-reproducibility-to-amber
branch
from
October 1, 2026 18:54
2c910c8 to
037b53c
Compare
13 tasks
mlieberman85
requested changes
Oct 6, 2026
mlieberman85
left a comment
Contributor
There was a problem hiding this comment.
This now conflicts with 0.1.1 and 044: reproducibility.toml gained effects/ceiling declarations, and its tests reference the framework by name. Before merge:
packaging/pypi/public-packages.txtstill listsdarnit-reproducibility, so the release preflight and build fail.- Upgrade path:
pip install -U darnit-mcpwould leave darnit-reproducibility installed and failing to load. It needs a finaldarnit-reproducibilityrelease that depends on darnit-amber, or the distribution name kept. - Update the tests that still expect the
reproducibilityframework name (test_plan_contract.pyand the 044 reproducibility tests), anddocs/getting-started/using-skills.md. - Add a CHANGELOG entry (breaking) and a linked issue or decision record.
- Rebase after #519 lands; its Dockerfile loop and smoke matrix need the new name.
Drafted with Claude Code; reviewed and posted by me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reproducibility module is becoming Amber. This renames it in place - it stays a darnit plugin under
packages/, same as the others.Names chosen to match existing conventions: package
darnit-amber(every other plugin isdarnit-*), frameworkamber(every other framework is the bare domain -openssf-baseline,community-spec,gittuf).What changed
packages/darnit-reproducibility→packages/darnit-amber, moduledarnit_reproducibility→darnit_amber, classReproducibilityImplementation→AmberImplementationreproducibility.toml→amber.toml; framework and MCP server namereproducibility→amberdarnit.frameworksanddarnit.implementations, plus the implementation'snameproperty - that last one is whatdiscovery.pykeys the registry by, so the rename doesn't work without itdocs/design/reproducibility-attestation-system.md→amber-attestation-system.mdBreaking
--framework reproducibilitybecomes--framework amber.darnit-reproducibilityon PyPI is superseded bydarnit-amber(neither name exists on TestPyPI yet; see #519).Upgrading in place needs
uv sync --reinstall, not plainuv sync. The old editable install leaves adarnit_reproducibilityentry point behind, which then fails to load and masks the new one. Clean environments (CI) aren't affected.Type of Change
Testing
tests/darnit_amber+tests/darnit/sieve+tests/darnit/test_plugin_handler_registration.py+tests/packaging: 293 passed, 4 skipped.darnit listshowsamberwith its 5 controls;darnit audit --framework amberruns them end to end.AI assistance
Left alone deliberately
specs/- 20 files mention the old name, but they're records of what was built at the time. Rewriting them would double the diffaudit_reproducibilityMCP tool inamber.toml- renaming a tool breaks any agent config that references it. Separate change if we want it.