Skip to content

Use calloc and dt_strlcpy_to_fixed in `overlay. - #22209

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
masterpiga:fix_overlay_malloc
Sep 8, 2026
Merged

Use calloc and dt_strlcpy_to_fixed in `overlay.#22209
TurboGit merged 1 commit into
darktable-org:masterfrom
masterpiga:fix_overlay_malloc

Conversation

@masterpiga

@masterpiga masterpiga commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Fix uninitialized heap bytes leaking into history, database, pixelpipe hashes, and sidecar files during v1 $\to$ v2 parameter migration in legacy_params()in the overlay module.

A relative of #21148.

EDIT: The issue was brought to my attention by @kofa73. Thanks!

@masterpiga
masterpiga requested a review from kofa73 September 8, 2026 11:34
@masterpiga masterpiga added this to the 5.8 milestone Sep 8, 2026
@masterpiga masterpiga added bugfix pull request fixing a bug priority: low core features work as expected, only secondary/optional features don't labels Sep 8, 2026

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
TurboGit merged commit d213a37 into darktable-org:master Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug priority: low core features work as expected, only secondary/optional features don't

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants