Skip to content

Additional button to remove the star rating of an image - #22077

Closed
deekayhd wants to merge 5 commits into
darktable-org:masterfrom
deekayhd:remove_star_rating
Closed

Additional button to remove the star rating of an image#22077
deekayhd wants to merge 5 commits into
darktable-org:masterfrom
deekayhd:remove_star_rating

Conversation

@deekayhd

Copy link
Copy Markdown
Contributor

This is a proposal for issue #21127 .
Currently, the only way to remove the star rating of an image is either by using the shortcut 0 or by clicking the first star in a toggle fashion. When more than one star has been set for an image, you have to click the first star twice. This is not very intuitive.
With this PR a new dedicated button is introduced at the bottom of the lighttable to remove the star rating of an image in the same fashion as setting the rating.

image

@TurboGit This is the replacement for my previous PR #21199, where we discussed this addition already.

closes #21127

@deekayhd deekayhd changed the title Remove star rating Additional button to remove the star rating of an image Aug 30, 2026
@TurboGit

Copy link
Copy Markdown
Member

As announced here : #22048

I now request a release note entry for new features and fixes if from a previous released versions.

@TurboGit TurboGit added this to the 5.8 milestone Aug 30, 2026
@TurboGit TurboGit added feature: enhancement current features to improve priority: low core features work as expected, only secondary/optional features don't scope: DAM managing files, collections, archiving, metadata, etc. release notes: pending labels Aug 30, 2026
@deekayhd

Copy link
Copy Markdown
Contributor Author

I now request a release note entry for new features and fixes if from a previous released versions.

Sure. Done.

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit

Copy link
Copy Markdown
Member

@deekayhd : Please never merge master into your topic branch, the policy is to rebase. You have probably use the GitHub button to resolve the conflict, this is not the right way. I'll handle this manually, just so you know for the next time.

@TurboGit TurboGit closed this Aug 31, 2026
@TurboGit

Copy link
Copy Markdown
Member

Manually merged.

@anoderay anoderay added the documentation: pending a documentation work is required label Aug 31, 2026
@deekayhd

Copy link
Copy Markdown
Contributor Author

@deekayhd : Please never merge master into your topic branch, the policy is to rebase. You have probably use the GitHub button to resolve the conflict, this is not the right way. I'll handle this manually, just so you know for the next time.

@TurboGit Sorry for the hassle. Yes, I had some conflicts after publishing my feature branch to my fork. I tried to rebase locally, but I couldn't get rid of the conflict (so far I never had to deal with any). I guess I should have rebased before ever publishing the feature branch. My last desperate measure was then to use the button in Github :-(
I found this: https://github.com/darktable-org/darktable/wiki/Hacking-on-darktable
and I thought I did as described (although in VScode).
Is there any other description of the correct procedure?
Sorry again for the effort.

@TurboGit

Copy link
Copy Markdown
Member

After a rebase if you have conflict you need:

  • To edit each file with a conflict (check git status)
  • Fix the conflict - that is removing the >>>>>> & <<<<< sections and keeping the proper code/text. That's the hard part sometime.
  • Record the edited files as ready/ok : git add <file>
  • Then continue the rebase: git rebase --continue

And redo this whole procedure if more conflicts are found.

@deekayhd

Copy link
Copy Markdown
Contributor Author

After a rebase if you have conflict you need: ...

Well, this is what I did, but in VSCode, not on the command line. I hope I can manage to do it properly the next time.

@deekayhd
deekayhd deleted the remove_star_rating branch August 31, 2026 18:52
@Phemisters Phemisters added documentation: complete needed documentation is merged in dtdocs and removed documentation: pending a documentation work is required labels Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation: complete needed documentation is merged in dtdocs feature: enhancement current features to improve priority: low core features work as expected, only secondary/optional features don't scope: DAM managing files, collections, archiving, metadata, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX: No way to mark a photo as not rated on the lightable

4 participants